-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Updated daemonset for taints and tolerations. #2776
Conversation
## How Daemon Pods work with taints and tolerations | ||
|
||
Daemon pods will not be deleted by `NodeController` in case of node problems, such as when node turns to | ||
`Unreachable` or `NotReady`. The reason is that the `NodeController` added an infinite tolerations of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence doesn't read well to me and it is quite long. Consider replacing "the reason" and rephrasing "added an infinite tolerations".
Toleration is a verb and should not include an "s".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Daemon pods/Daemonset pods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/added/adds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NodeController
will not delete Daemonset pods in case of node problems, such as a node being Unreachable
or NotReady
, because the NodeController
adds infinite toleration for Unreachable
and NotReady
taints.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daemonset has its own controller and node controller just adds the taints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: @mburke5678 |
I noticed another thing we need to change in that doc, so I just went ahead and made all of the changes in a new PR #2905 so I'm going to close this one. |
Fixed part of #2737
This change is